Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glTF 1.0.1 default material #4251

Closed

Conversation

lasalvavida
Copy link
Contributor

Part of #4009. Merge #4249 first.

@lasalvavida lasalvavida changed the title Gltf 1.0.1 default material glTF 1.0.1 default material Aug 29, 2016
@lasalvavida lasalvavida mentioned this pull request Aug 29, 2016
23 tasks
@lasalvavida lasalvavida changed the base branch from master to gltf-1.0.1 August 30, 2016 14:39
@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 30, 2016

CC @lexaknyazev - glTF 1.0.1

@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 30, 2016

Couldn't this use or adapt modelMaterialsCommon.js like gltfDefaults.js?

@lasalvavida lasalvavida force-pushed the gltf-1.0.1-default-material branch from ecceac4 to 8cb3ca7 Compare November 11, 2016 18:06
@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2017

@lasalvavida should we close this PR and open a new one when 1.1 changes are ready?

@lasalvavida
Copy link
Contributor Author

Yes. This will actually just be part of the gltf pipeline integration.

@lasalvavida lasalvavida closed this Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants