Fix imagery crash #4258
Merged
Fix imagery crash #4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ImageryLayer._reprojectTexture` was performing an asynchronous operation without callimg `imagery.addReference` or `imagery.releaseReference` which was causing the imagery and it's resources to be destroyed if culled before the reprojection was complete, leading to us trying to destroy an already destroyed texture.
|
Fixes #4083 |
|
Thanks! |
andrewkfiedler
added a commit
to codice/ddf-ui
that referenced
this pull request
Oct 12, 2016
- Removed apply and updated saving to be automatic. As such, the map is no longer necessary (you can watch the main map update in real time). - Removed checkboxes in favor of clicking on the layer name. - Added opacity indication of whether or not a layer is shown. - Upgraded to latest cesium in order to pull in CesiumGS/cesium#4258, which had been causing issues with hiding and showing of layers too quickly (cesium would crash).
rzwiefel
pushed a commit
to codice/ddf-ui
that referenced
this pull request
Oct 24, 2016
- Removed apply and updated saving to be automatic. As such, the map is no longer necessary (you can watch the main map update in real time). - Removed checkboxes in favor of clicking on the layer name. - Added opacity indication of whether or not a layer is shown. - Upgraded to latest cesium in order to pull in CesiumGS/cesium#4258, which had been causing issues with hiding and showing of layers too quickly (cesium would crash).
rzwiefel
pushed a commit
to codice/ddf-ui
that referenced
this pull request
Dec 9, 2016
- Removed apply and updated saving to be automatic. As such, the map is no longer necessary (you can watch the main map update in real time). - Removed checkboxes in favor of clicking on the layer name. - Added opacity indication of whether or not a layer is shown. - Upgraded to latest cesium in order to pull in CesiumGS/cesium#4258, which had been causing issues with hiding and showing of layers too quickly (cesium would crash).
pklinef
pushed a commit
to codice/ddf-ui
that referenced
this pull request
Dec 23, 2016
DDF-2644 DDF-2644 - Removed apply and updated saving to be automatic. As such, the map is no longer necessary (you can watch the main map update in real time). DDF-2644 - Removed checkboxes in favor of clicking on the layer name. DDF-2644 - Added opacity indication of whether or not a layer is shown. DDF-2644 - Upgraded to latest cesium in order to pull in CesiumGS/cesium#4258, which had been causing issues with hiding and showing of layers too quickly (cesium would crash).
pklinef
pushed a commit
to codice/ddf-ui
that referenced
this pull request
Dec 23, 2016
- Removed apply and updated saving to be automatic. As such, the map is no longer necessary (you can watch the main map update in real time). - Removed checkboxes in favor of clicking on the layer name. - Added opacity indication of whether or not a layer is shown. - Upgraded to latest cesium in order to pull in CesiumGS/cesium#4258, which had been causing issues with hiding and showing of layers too quickly (cesium would crash).
pklinef
pushed a commit
to codice/ddf-ui
that referenced
this pull request
Dec 23, 2016
- Removed apply and updated saving to be automatic. As such, the map is no longer necessary (you can watch the main map update in real time). - Removed checkboxes in favor of clicking on the layer name. - Added opacity indication of whether or not a layer is shown. - Upgraded to latest cesium in order to pull in CesiumGS/cesium#4258, which had been causing issues with hiding and showing of layers too quickly (cesium would crash).
rzwiefel
pushed a commit
to rzwiefel/ddf
that referenced
this pull request
Jan 5, 2017
- Removed apply and updated saving to be automatic. As such, the map is no longer necessary (you can watch the main map update in real time). - Removed checkboxes in favor of clicking on the layer name. - Added opacity indication of whether or not a layer is shown. - Upgraded to latest cesium in order to pull in CesiumGS/cesium#4258, which had been causing issues with hiding and showing of layers too quickly (cesium would crash).
shaundmorris
pushed a commit
to shaundmorris/ddf
that referenced
this pull request
Mar 29, 2017
- Removed apply and updated saving to be automatic. As such, the map is no longer necessary (you can watch the main map update in real time). - Removed checkboxes in favor of clicking on the layer name. - Added opacity indication of whether or not a layer is shown. - Upgraded to latest cesium in order to pull in CesiumGS/cesium#4258, which had been causing issues with hiding and showing of layers too quickly (cesium would crash).
rzwiefel
pushed a commit
to codice/ddf-ui
that referenced
this pull request
Nov 8, 2019
- Removed apply and updated saving to be automatic. As such, the map is no longer necessary (you can watch the main map update in real time). - Removed checkboxes in favor of clicking on the layer name. - Added opacity indication of whether or not a layer is shown. - Upgraded to latest cesium in order to pull in CesiumGS/cesium#4258, which had been causing issues with hiding and showing of layers too quickly (cesium would crash).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageryLayer._reprojectTexturewas performing an asynchronous operation without callimgimagery.addReferenceorimagery.releaseReferencewhich was causing the imagery and it's resources to be destroyed if culled before the reprojection was complete, leading to us trying to destroy an already destroyed texture.