Animation widget #458
Animation widget #458
Conversation
Conflicts: Apps/TimelineDemo/TimelineDemo.js
…ay or may not have resulted from auto-upgrading to Firefox 17).
…w (although touch events have yet to be added, awaiting new event system from camera/pinch-zoom branches).
Conflicts: Source/Widgets/Dojo/CesiumViewerWidget.js
…R, added a realtime mode, added loop option to widget.
All tests currently pass in Chrome 23 with ANGLE on.
|
For auto-snapping, I was briefly looking at: http://html2canvas.hertzen.com/ I don't think we need to redo all the thumbnails. Even before this change, many of them didn't match anyway. |
| throw new DeveloperError('timeFormatter must be a function.'); | ||
| } | ||
| this._timeFormatter(timeFormatter); | ||
| this._timeFormatter.notifySubscribers(); |
There was a problem hiding this comment.
I assume that this is to work around the default equalityComparer which only works with primitive types. Should we use a different equalityComparer instead of manually notifying?
There was a problem hiding this comment.
Actually, it was from an earlier version of the code and is no longer needed. I removed this and the other _dateFormatter.notifySubscribers call.
|
I was on that same site today. I even went as far to install grunt and cloned and built it. Haven't tried to use it yet since I realized we need to update other things, like good default views for each example. |
|
I think all of your review comments have been addressed (either my changing the code or in my responses above). If there's anything else, let me know. Otherwise, merge when you're ready. |
|
I realized CHANGES was out of date, so I updated it with details of the huge amount of things that happened in this pull. Ready for "final" review if you are. |
|
Guys, I looked at this briefly and it seems reasonable to me. Unless you think it would be worthwhile for me to do a more extensive review, you can put me down in the "merge it" column. |
|
Good enough for me. @shunter merge when ready. |
Touch controls for animation widget.
… that browser globals will be available.
|
@emackey Do you want to write a blog entry that gives an overview of the new Animation widget and also talks about using SVG and other modern UI/HTML design? You could also highlight some of the hiccups you encountered and get some traction for the two HTML5 blob bugs you submitted. It would be nice if we had something up at the end of the week to go along with the b14 release. Do you have time to put something together? If not, I can look into doing it and you can just proof it. |
New widget for controlling time, and updated API in Clock/AnimationController to match new actions offered by the widget.