(fix) display tooltips on All demos view #4702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emackey do you want to look at this? |
|
@tekhaus we updated electron in master, so if you update your branch CI should pass |
|
@hpinkos merged from upstream master and pushed to my fork... how do I get CI to rerun on this PR ? |
|
merge your fork's master into this branch and push that up. That should make CI run again |
|
Thanks @tekhaus, I can confirm this fixes the problem. There were some merge issues with your branch, so I just merged master and pushed that up. |
|
Oh actually, before I merge this, can you add yourself to https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTORS.md? |
|
Also, one last small request: please update CHANGES.md. |
|
@pjcozzi I'll update CHANGES in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4454