Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize performance when normal and tangent are not necessary #4781

Closed
wants to merge 4 commits into from
Closed

Conversation

pasu
Copy link
Contributor

@pasu pasu commented Dec 24, 2016

No description provided.

@pasu pasu changed the title optimizer performance when normal and tangent are not necessory optimize performance when normal and tangent are not necessary Dec 24, 2016
@hpinkos
Copy link
Contributor

hpinkos commented Dec 27, 2016

Thanks @pasu, good catch!

@hpinkos
Copy link
Contributor

hpinkos commented Dec 27, 2016

@pasu Do we have a CLA (Contributor's License Agreement) from you? If not, can you please send one over so we can merge this? You can find instructions here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla

Thanks!

@pasu
Copy link
Contributor Author

pasu commented Dec 29, 2016

I add name to CONTRIBUTORS.md
But it seems there is a conflict and I have no access to modify it
It is my pleasure to make this little contribution and I hope I can make more contributions in the next year
I really think Cesium is a great virtual globe project.

@pasu
Copy link
Contributor Author

pasu commented Jan 4, 2017

Shall I close this request?
It is a small improvement,and I feel a little shy to interrupt you:)
@hpinkos

@hpinkos
Copy link
Contributor

hpinkos commented Jan 4, 2017

@pasu this is a good fix and we'd love to take it! I'm not sure if we've received your signed CLA though. Did you email that over to us? That's the only thing holding this up, the code looks good to me =)

@hpinkos
Copy link
Contributor

hpinkos commented Feb 3, 2017

Hi @pasu! Our contracts department is being really slow to review your CLA, so I opened my own pull request with this fix so we can get it merged in for the next release #4948

Thanks for bringing this up! It's a good improvement.

@hpinkos hpinkos closed this Feb 3, 2017
@pasu
Copy link
Contributor Author

pasu commented Feb 15, 2017

OK so glad to see it @hpinkos

last week, it was the Chinese Spring Festive, that is why I did not visit here in time,
Happy Chinese new year~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants