Prevent normalizing zero vector #5010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we try to figure out why there are vertices where the normal is being computed as zero? It seems like this would only happen if the vertex isn't actually being used in the mesh. The whole reason we added this 'don't normalize the zero vector' developer error is to more easily detect invalid values coming in, so I don't think working around it like this is a good way to go about it. |
|
Does the model have degenerate triangles? |
|
Yes most likely. |
|
Wouldn't we be better off with a stage that removes degenerate triangles in gltf-pipeline? |
|
Yes I'm thinking that's best as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeometryPipeline.computeNormalis used by gltf-pipeline and will fail on some models when generating normals. This just checks if the normal is zero before trying to normalize. Maybe not the best fix, but definitely the easiest.Some more discussion here: #4863 (comment)