Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update children transforms before checking their union for culling #5211

Merged
merged 1 commit into from
Apr 18, 2017
Merged

update children transforms before checking their union for culling #5211

merged 1 commit into from
Apr 18, 2017

Conversation

austinEng
Copy link
Contributor

@pjcozzi @rahwang This fixes the culling problems we were seeing in the game

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 17, 2017

@rahwang could you please test this? Feel free to just keep the game built off of this branch until @lilleyse is able to review and merge this.

@rahwang
Copy link
Contributor

rahwang commented Apr 17, 2017

Works great! Thanks, @austinEng !

@lilleyse
Copy link
Contributor

Thanks for the fix.

@lilleyse lilleyse merged commit 8153ff3 into CesiumGS:3d-tiles Apr 18, 2017
@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 18, 2017

Thanks @austinEng @rahwang @lilleyse! Good eye and fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@austinEng @pjcozzi @rahwang @lilleyse