Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix billboard clamping bug #5339

Merged
merged 1 commit into from
May 18, 2017
Merged

Fix billboard clamping bug #5339

merged 1 commit into from
May 18, 2017

Conversation

mramato
Copy link
Contributor

@mramato mramato commented May 18, 2017

Clear the current clamped position if the new position is not clampable.

In master, the below code has no effect when setting the billboard position to Cartesian3.ZERO, this branch properly updates the billboard:

var viewer = new Cesium.Viewer('cesiumContainer');

var billboards = new Cesium.BillboardCollection({scene: viewer.scene});
viewer.scene.primitives.add(billboards);

var b = billboards.add({
    position : Cesium.Cartesian3.fromDegrees(-75, 45),
    image : '../images/facility.gif',
    heightReference : Cesium.HeightReference.CLAMP_TO_GROUND
});

Sandcastle.addToolbarButton('Set position', function(){
    b.position = Cesium.Cartesian3.ZERO;
});

Fixes #5338

Clear the current clamped position if the new position is not clampable.

Fixes #5338
@mramato mramato requested a review from bagnell May 18, 2017 01:59
@bagnell bagnell merged commit 839bbb2 into master May 18, 2017
@bagnell bagnell deleted the clamping-caching-calamity branch May 18, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants