Update MIME type for glb files #5420
Conversation
|
Model.js has a list of accepted model mime types that also needs to be updated. |
|
Thanks @mramato. |
|
For the Model.js change, are we okay with only requesting the official mime types and not the older versions? Technically that's a breaking change (though I doubt many people rely on it). |
|
We've got |
Source/Scene/Model.js
Outdated
| @@ -154,8 +154,8 @@ define([ | |||
| FAILED : 3 | |||
| }; | |||
|
|
|||
| // GLTF_SPEC: Figure out correct mime types (https://github.com/KhronosGroup/glTF/issues/412) | |||
| var defaultModelAccept = 'model/vnd.gltf.binary,model/vnd.gltf+json,model/gltf.binary,model/gltf+json;q=0.8,application/json;q=0.2,*/*;q=0.01'; | |||
| // GLTF_SPEC: Figure out correct mime types (https://github.com/KhronosGroup/glTF/issues/412 and https://github.com/KhronosGroup/glTF/issues/943) | |||
There was a problem hiding this comment.
Sorry, last comment. Is this comment still needed? 1.0 and 2.0 specs are done and all mime types are known, right?
|
Good point about that comment. I wanted to keep the links, but I changed the rest of the wording to sound more final and less like a TODO. |
# Conflicts: # CHANGES.md
|
This is ready. |
|
Whoops, thought I merged this. |
|
Thanks @emackey! |
This was changed in KhronosGroup/glTF#943.
Also fixed an eslint warning in
server.js.