BoundingSphere and Cartesian functions #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| result = new BoundingSphere(); | ||
| } | ||
|
|
||
| var center = Cartesian3.add(corner, oppositeCorner); |
There was a problem hiding this comment.
You could use result.center as the result to add to avoid creating one or two new Cartesian3s.
There was a problem hiding this comment.
Yeap. Updated. Please retest; I used the GitHub editor. Questionable, I know.
|
Just the one comment. Otherwise, looks good and the tests pass. |
|
Tests pass. Merging. |
bagnell
added a commit
that referenced
this pull request
Mar 7, 2013
BoundingSphere and Cartesian functions
| }); | ||
|
|
||
| it('fromCornerPoints with a result parameter', function() { | ||
| var sphere = new BoundingSphere; |
There was a problem hiding this comment.
The first time the new ant jsHint command caught something for me 😄 I'll fix this since you sounded like you were busy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the models branch:
BoundingSphere.fromCornerPoints.fromArrayanddistancefunctions toCartesian2,Cartesian3, andCartesian4.Longer-term we want to masquerade arrays as Cartesians, but these functions are orthogonal to that effort.