Add setter for GeoJsonDataSource.name #5656
Conversation
|
@mramato do you have any idea why CI is failing? It's doing that on a couple of my branches |
| @@ -690,6 +690,12 @@ define([ | |||
| name : { | |||
| get : function() { | |||
| return this._name; | |||
| }, | |||
| set : function(value) { | |||
There was a problem hiding this comment.
Should probably update the comment above to indicate the name can be changed
There was a problem hiding this comment.
Good call, thanks! I just pushed an update to the doc
There was a problem hiding this comment.
I need to double check in the code, but I don't think we want to raise the _changed event, here. I think that event is meant for underlying Entity changes, which would basically cause more work to be done than needed if we raise it here. But like I said, I need to check how we are using it.
There was a problem hiding this comment.
I copied this from CustomDataSource FYI
There was a problem hiding this comment.
OK, looking at the code we don't seem to use this internally other than setting the DataSource clock in viewer, so this is fine as is.
Fixes #5653