added HBAO and DOF #5673
added HBAO and DOF #5673
Conversation
added HBAO and DOF
|
It might just be my eyes or the test scene, but it is hard for me to see the DOF effect in these screenshots? Is the blur blurry enough? And is the focus area small enough? Did you create a Sandcastle example with sliders for the various parameters? |
|
Yes, it would be better to check the difference with Sandcastle because there are parameters for that |
Added stepsize parameter at DOF
add Bloom(Glow) abd EdgeDetection(Toon) Fixed a HBAO's artifact which draws unexpected lines Glow - http://localhost:8080/Apps/Sandcastle/?src=Hello%20World.html&label=Showcases&gist=d5fd85d0eaec2a91fb9548ec8d8fbea4 Toon - http://localhost:8080/Apps/Sandcastle/?src=Hello%20World.html&label=Showcases&gist=87ac93ad6ac8df9c78894ba242416450
| <meta charset="utf-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=no"> | ||
| <meta name="description" content="Change color of 3D models."> |
There was a problem hiding this comment.
Change the description. Also applies to the other Sandcastle demos.
| @@ -0,0 +1,135 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Rename the file to "Depth of Field" so it is clear to those not familiar with the acronym.
| <meta charset="utf-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=no"> | ||
| <meta name="description" content="Change color of 3D models."> |
| <tr> | ||
| <td>Depth Of Field</td> | ||
| <td> | ||
| <input type="checkbox" data-bind="checked: DOFShow"> |
There was a problem hiding this comment.
Rename to depthOfFieldShow.
| <tr> | ||
| <td>Focal Distance</td> | ||
| <td> | ||
| <input type="range" min="0.0" max="500.0" step="1" data-bind="value: FocalDistance, valueUpdate: 'input'"> |
There was a problem hiding this comment.
Use lower-case names instead - focalDistance, kernelSize, etc.
| ' isSpace = false; \n' + | ||
|
|
||
| //Sun position | ||
| ' vec4 sunPos; \n' + |
| */ | ||
| this.lensFlare = PostProcessLibrary.lensFlare; | ||
|
|
||
| this.bloom = PostProcessLibrary.bloom; |
There was a problem hiding this comment.
bloom is missing the documentation.
| * @private | ||
| */ | ||
| function PostProcessToonStage() { | ||
|
|
| */ | ||
| function PostProcessToonStage() { | ||
|
|
||
| this._ToonTexture = undefined; |
There was a problem hiding this comment.
Rename to this._toonTexture. Also lower-case the other variables here.
| }; | ||
|
|
||
| return PostProcessToonStage; | ||
| }); |
|
I made a cleanup improvements to |
|
I addressed all comments in another branch. I'll open a separate PR with the fixes. |
added HBAO and DOF with using PostprocessStage Composition (Gaussian Blur)