Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to knockout 3.4.2 #5829

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Update to knockout 3.4.2 #5829

merged 2 commits into from
Sep 14, 2017

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Sep 14, 2017

Knockout fixed some bugs and performance issues. I tested all of our widgets and nothing seems like it needed to be changed.

@hpinkos hpinkos requested a review from mramato September 14, 2017 19:46
@mramato
Copy link
Contributor

mramato commented Sep 14, 2017

We usually update CHANGES for this kind of stuff (not sure why the concierge hasn't kicked in yet).

@mramato
Copy link
Contributor

mramato commented Sep 14, 2017

Also update LICENSE because the copyright has changed.

@hpinkos
Copy link
Contributor Author

hpinkos commented Sep 14, 2017

@mramato ready

@mramato
Copy link
Contributor

mramato commented Sep 14, 2017

👍 Thanks.

@ggetz if the concierge doesn't post to this PR by the time you read this, it might be a good idea to try and figure out why. (This is the first time I've seen it not post to a PR).

@mramato
Copy link
Contributor

mramato commented Sep 14, 2017

I'll merge this as soon as the tests pass.

@mramato mramato merged commit 2fa9955 into master Sep 14, 2017
@mramato mramato deleted the update-knockout branch September 14, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants