-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow local-running Cesium to load its resources #5831
Conversation
Welcome to the Cesium community @pizza2code! Can you please send in a Contributor License Agreement (CLA) so that we can review and merge this pull request? I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to I am a bot who helps you make Cesium awesome! Thanks again. |
Hi @pizza2code , thanks for the PR! So this issue of using the file protocol with Cesium has come up before, see #5326 and #3935 Instead of this change, we'd reccomend using something like Electron to run your app. See our blog post on getting that set up here: https://cesium.com/blog/2016/04/04/an-introduction-to-cesium-desktop-apps-with-electron/ |
@hpinkos Can we consider reopening this? Sorry for the additional noise. Also, per that comment, we can skip the |
Actually, I think checking for file protocol will still be necessary. From reading the spec, "0" would appear to be a valid error indication for a network-level error for HTTP requests. |
OK, thanks @shunter ! |
@pizza2code we can't merge this until you send in a CLA (as noted above). Since this is a small change, if you are unable or don't want to fill out a CLA, I can make the change myself in a different PR. Just let us know either way. Thanks for the PR either way! |
@mramato Sorry, not sure I'll be able to sign the CLA due to clauses in my employment agreement. You can go ahead and make the change (you're right, it's pretty small) in another PR. :) |
Thanks @pizza2code! I've opened a PR to add the changes here: #5892 |
Fixes #5830