Change SVG colors to not use RGBA (technically not allowed). #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return {String} The CSS equivalent of this color, minus its Alpha. | ||
| * @see <a href="http://www.w3.org/TR/css3-color/#rgb-color">CSS RGB color values</a> | ||
| */ | ||
| Color.prototype.toCssColorStringNoAlpha = function() { |
There was a problem hiding this comment.
Would toCssRgbString and toCssRgbaString make better names?
There was a problem hiding this comment.
Could be. It would be a breaking API change, but I don't know if this API really has that many users. I'm fine renaming these to whatever people think is best. Any other opinions on this before I rename?
|
Also, how about some tests for the new version (by just copying the rgba ones and removing the alpha). |
|
I'll add some tests. |
|
We could change toCssColor to use either rgb or rgba syntax depending on whether alpha is 1 or not. If you are using it with SVG then you should already be using alpha of 1, right? |
|
Ready for another review. |
mramato
added a commit
that referenced
this pull request
Mar 22, 2013
Change SVG colors to not use RGBA (technically not allowed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All our target browsers allowed us to use RGBA for a
linearGradient: stop-color, but technically it's not in the SVG spec. SVG definesstop-opacityandstop-colorseparately, and thestop-opacityis the only place where alpha values work.When I tried to export a new copy of the Animation widget into Inkscape (which hasn't happened in a long time), the colors came out black because we're not following the SVG spec.
So, this pull request brings us back into compliance, but there should be no visible changes in the browser as a result. In particular, the translucent parts of the Animation widget should be completely un-changed by this pull.