Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drill picking ground primitives #6017

Merged
merged 4 commits into from
Nov 30, 2017
Merged

Fix drill picking ground primitives #6017

merged 4 commits into from
Nov 30, 2017

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Nov 30, 2017

Update classification primitive pick commands to use show attribute. Fixes #5971.

@cesium-concierge
Copy link

Signed CLA is on file.

@bagnell, thanks for the pull request! Maintainers, we have a signed CLA from @bagnell, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@pjcozzi pjcozzi requested a review from tfili November 30, 2017 19:05
@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 30, 2017

Is it possible to add a reasonable unit test to this?

@bagnell
Copy link
Contributor Author

bagnell commented Nov 30, 2017

Is it possible to add a reasonable unit test to this?

Yes, added.

@tfili
Copy link
Contributor

tfili commented Nov 30, 2017

Thanks @bagnell. Works great.

@tfili tfili merged commit 70aa664 into master Nov 30, 2017
@tfili tfili deleted the drill-pick branch November 30, 2017 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants