Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when using invert classification and resizing the window #6062

Merged
merged 3 commits into from
Dec 17, 2017

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Dec 15, 2017

  • Fix crash when resizing window and invert classification in enabled.
  • Do not update FBOs when picking as they are not used.

Fixes #6046.

@cesium-concierge
Copy link

Signed CLA is on file.

@bagnell, thanks for the pull request! Maintainers, we have a signed CLA from @bagnell, so you can review this at any time.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 17, 2017

Looks good. Please open a separate PR if it is possible to add a reasonable unit tests.

@pjcozzi pjcozzi merged commit 7b6c966 into master Dec 17, 2017
@pjcozzi pjcozzi deleted the invert-crash branch December 17, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants