Deprecation for resources #6120
Conversation
|
@tfili, thanks for the pull request! Maintainers, we have a signed CLA from @tfili, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Source/Renderer/loadCubeMap.js
Outdated
| @@ -66,6 +68,10 @@ define([ | |||
| } | |||
| //>>includeEnd('debug'); | |||
|
|
|||
| if (defined(allowCrossOrigin)) { | |||
| deprecationWarning('loadCubeMap.allowCrossOrigin', 'The allowCrossOrigin parameter has been deprecated. It no longer needs to be specified.'); | |||
There was a problem hiding this comment.
This function is private, so we shouldn't need to deprecate anything.
| @@ -106,6 +107,10 @@ define([ | |||
| } | |||
| //>>includeEnd('debug'); | |||
|
|
|||
| if (defined(options.headers)) { | |||
There was a problem hiding this comment.
This is private as well, so we shouldn't need this deprecation.
|
Just those comments, nothing else jumps out at me (and this will get another look in the main PR) so once you address them I'll merge (or you can just merge yourself since this goes into a branch). |
A bunch of places now take a
Resourceas a url. Some of these classes also took other parameters that are now part of the resource (eg. proxy, headers, query). These parameters have been deprecated since they can be passed in as part of the resource instance.