-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix allow local-running Cesium to load its resources for Chromium #6197
Conversation
@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
@thw0rted this should fix your issue, right? Hope you get your CLA issues figured out. It would be great to have you as a contributor! |
I have tested the change and it does resolve the issue for my specific use case (in Chrome/Chromium, with |
Trackback to #5830 |
Can someone review this? @emackey? |
I've been meaning to test the new resource stuff in VSCode, haven't gotten there yet. In the meantime, this change seems fine for Chromium. The same behavior is not present in Firefox (origin is null for local files) but presumably one wouldn't run Cesium in a stand-alone Firefox engine the way one does for Electron/Chromium. @hpinkos If you like I can build Cesium locally with and without this change and test the behavior out inside a VSCode plugin. Or you could just merge this, it looks fine. |
Just as a data point, I think our customers are more likely to run our product offline in Firefox than Chrome, just based on how the software baseline is set up, but I wouldn't expect it to be *common. I'm also fairly certain that the above change wouldn't affect Firefox because I don't think it returns |
Thanks @emackey! I think I'm just going to merge this now |
Thanks @thw0rted, this is merged and will be included in Cesium 1.43 |
Does this warrant an update to CHANGES.md? |
See #5892 (comment)