DataSources batch different geometry types together #6239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating one
GeometryVisualizer
per geometry type, we now create oneGeometryVisualizer
that handles all of the geometry types. This allows us to batch more geometries together at the DataSource level.This does include some breaking changes because params changed for
GeometryVisualizer
andGeometryUpdater
Other details:
PolylineVisualizer
for handling polylinesGeometryVisualizer
GeometryVisualizer
handles box, corridor, ellipse, ellipsoid, plane, polygon, polyline volume, rectangle and wall<Type>GeometryUpdater.id
. This is needed so a batch can include multiple geometry related to the same entity.