Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JSDoc to correctly document Cesium.Math.* #6244

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Conversation

emackey
Copy link
Contributor

@emackey emackey commented Feb 21, 2018

Fixes #6233.

@cesium-concierge
Copy link

Signed CLA is on file.

@emackey, thanks for the pull request! Maintainers, we have a signed CLA from @emackey, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Feb 21, 2018

Thanks @emackey! I would make a comment in CHANGES.md since this was a doc error reported by our users

@emackey
Copy link
Contributor Author

emackey commented Feb 21, 2018

Done.

@hpinkos
Copy link
Contributor

hpinkos commented Feb 21, 2018

Thanks @emackey!

@hpinkos hpinkos merged commit 15008c4 into master Feb 21, 2018
@hpinkos hpinkos deleted the fix-math-docs branch February 21, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants