Add default translation, rotation, scale to node targeted for animation #6351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emackey
approved these changes
Mar 20, 2018
There was a problem hiding this comment.
Looks great, fixes the problem. No tests were added, but our test harness is pretty coarse here and can't really tell if a node is being animated or not. Whoops, missed the comment about a test being added to pipeline. Nice!
Added one small suggestion, feel free to ignore :)
| var path = target.path; | ||
| // Ignore animations that target 'weights' | ||
| if (path === 'translation' || path === 'rotation' || path === 'scale') { | ||
| nodes[node] = true; |
There was a problem hiding this comment.
Just for readability's sake, can we rename the index variable here? Such as nodes[nodeId] = true; or similar.
|
@emackey Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6323
The animated triangle model (after modifications) now works.
@emackey can you take a look?
gltf-pipeline: CesiumGS/gltf-pipeline#356. A test is in that PR.