Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle system updates and sandcastle examples #6494

Merged
merged 40 commits into from
Apr 27, 2018
Merged

Conversation

hanbollar
Copy link

@hanbollar hanbollar commented Apr 25, 2018

Includes updates from the 2 added sandcastle examples for weather and comet/rocket demos and deprecations in Particle and Particle System.

All changes were previously reviewed and approved on the following 2 prev pull requests:
#6429 #6375

hanbollar and others added 30 commits April 5, 2018 10:56
… current issue is fireworks example is slightly wrong with this implementation. need to figure out why
…eprecations

Particle system updates and name changes
@cesium-concierge
Copy link

Signed CLA is on file.

@hanbollar, thanks for the pull request! Maintainers, we have a signed CLA from @hanbollar, so you can review this at any time.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@ggetz
Copy link
Contributor

ggetz commented Apr 25, 2018

Thanks @hanbollar, do you mind squashing your commits?

@hanbollar
Copy link
Author

can't squash because dont hv commit access. also the zip file failed to build.

@ggetz
Copy link
Contributor

ggetz commented Apr 27, 2018

Thanks @hanbollar!

@ggetz ggetz merged commit 910d9a2 into master Apr 27, 2018
@ggetz ggetz deleted the particle-system-updates branch April 27, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants