Cleanup Particle and Particle System for the 1.46 Release #6510
Conversation
|
@hanbollar, thanks for the pull request! Maintainers, we have a signed CLA from @hanbollar, so you can review this at any time. I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
CHANGES.md
Outdated
| ### 1.46 - 2018-06-01 | ||
|
|
||
| ##### Breaking Changes :mega: | ||
| * `ParticleSystem` no longer uses `forces`. [#]() |
|
@ggetz updated |
CHANGES.md
Outdated
|
|
||
| ##### Breaking Changes :mega: | ||
| * `ParticleSystem` no longer uses `forces`. [#6510](https://github.com/AnalyticalGraphicsInc/cesium/pull/6510) | ||
| * `Particle` no longer uses `size`, `rate`, `lifeTime`, `life`, `minimumLife`, `maximumLife`, `minimumWidth`, `minimumHeight`, `maximumWidth`, and `maximumHeight`. [#]() |
There was a problem hiding this comment.
lol woops i should hv caught that
|
@ggetz fixed |
|
@ggetz just following up - is there anything left for me to do for this for |
|
bump @ggetz |
Source/Scene/Particle.js
Outdated
| * @deprecated | ||
| * @type {Number} | ||
| */ | ||
| width : { |
There was a problem hiding this comment.
@ggetz do you think we should remove these width and height properties? They don't seem particularly useful since users can just access this.imageSize directly
There was a problem hiding this comment.
I'm fine with that, we'll just need to make sure it's updated in the tutorial if it was used there.
There was a problem hiding this comment.
They shouldn't be since they were added for the first time in the PR, but I'll double check
|
Looks good to me other than #6510 (comment) |
|
Thanks for cleaning this up @hanbollar! Hope you're having a good summer =) |
Fixes #6485
ParticleandParticleSystemfor 1.46SECOND DEPRECATION STAGE:
See Todos #6515