Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write log depth in vertex shader for upsampled terrain. #6701

Merged
merged 2 commits into from
Jun 19, 2018

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Jun 18, 2018

Fixes #6652.

@cesium-concierge
Copy link

Signed CLA is on file.

@bagnell, thanks for the pull request! Maintainers, we have a signed CLA from @bagnell, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Jun 19, 2018

Perfect, thanks @bagnell!

@hpinkos hpinkos merged commit fa0abb9 into master Jun 19, 2018
@hpinkos hpinkos deleted the fix-upsampled-clipping branch June 19, 2018 19:40
@lilleyse
Copy link
Contributor

While testing something else I ran into an issue that I think was introduced by this PR. Up close picking doesn't seem to work, at least in the vector tiles sandcastle demo.

picking

@mortac8
Copy link

mortac8 commented Jan 16, 2019

We are seeing black dots on the globe which seems to be related to this fix. We see it with ArcGisImageServerTerrainProvider which we still need and maintain.

bdots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants