Fix globe.pick for 2D/CV

[hpinkos]

This makes globe.pick return a position in 3D coordinates instead of world coordinates based on the scene mode, which is what users are expecting. We did a similar thing for scene.pickPosition.

This fixes imagery layer feature picking in 2D/Columbus View.

[cesium-concierge]

Thanks for the pull request @hpinkos!

• ✔️ Signed CLA found.
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

---

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

[hpinkos]

This is ready for review. I updated the first comment now that I have a better understanding of how our coordinates are supposed work. We did something similar for scene.pickPosition at some point, so I'm adding the same behavior to globe.pick.

[hpinkos]

@bagnell can you review please?

[bagnell]

The code looks good to me. Since this is a breaking change, are we sure we don't want to add a new function and deprecate the old one?

[hpinkos]

I think keeping it this way makes it consistent with what we did for pickPosition and I'm sure it's what users are expecting anyway. I would guess pretty much anyone using globe.pick now thinks it's broken in 2D/CV instead of knowing it's in the wrong projection. I can add a note to CHANGES though

[bagnell]

Since this has some of my code changes, someone else should review and merge. @mramato?

[hpinkos]

@bagnell this is ready

[mramato]

I'm only somewhat familiar with this code, but nothing jumped out as terrible to me. If both @bagnell and @hpinkos are happy and this passes, one of you can just hit merge.