Add geographic limit rectangle #6987

likangning93 · 2018-08-31T16:12:55Z

Needed for #6986, because some projections really really don't work well unless you clip out everything but the local area (EPSG 2039, for example).

This is distinct from clipping planes on the globe in that this respects curvy projections, which become possible in #6986. Keeping this separate also avoids adding extra complication to the clipping planes implementation.

Pretty pictures:

Coffee belt in 3D

Coffee belt in Columbus View

cesium-concierge · 2018-08-31T16:12:57Z

Thanks for the pull request @likangning93!

✔️ Signed CLA found.
❔ CHANGES.md was not updated.
- If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

Cesium Viewer works.
Works in 2D/CV.
Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

mramato · 2018-08-31T16:20:14Z

Nice! Please update CHANGES. People have been asking for this feature for a while (even without projections).

Does it work with both infinite scrolling and 2D map rotate modes?

We should probably wait until after the release to merge this, even if we think it's ready.

hpinkos · 2018-08-31T17:18:00Z

How hard would it be to get rid of the white seam at the IDL when east == west?
Did you check to make sure this works if east < west (ie the rectangle crosses the idl)

mramato · 2018-08-31T17:19:40Z

I assumed the outline was for the screenshots, is there a need to have it at all in production?

likangning93 · 2018-09-06T14:23:05Z

Whoops, sorry for the slow response.

I assumed the outline was for the screenshots, is there a need to have it at all in production?

Yes, outline was for screenshots and demos. I thought it would be helpful since we don't draw the backsides of terrain.

Did you check to make sure this works if east < west (ie the rectangle crosses the idl)

Not working, I'll try getting that fixed soon.

Does it work with both infinite scrolling and 2D map rotate modes?

I think so, but using a limiter that that covers less than -180 to 180 longitude will be discontinuous:

bagnell · 2018-09-06T21:17:26Z

Source/Scene/GlobeSurfaceShaderSet.js

@@ -84,6 +84,13 @@ define([
            vertexLogDepthDefine = 'DISABLE_GL_POSITION_LOG_DEPTH';
        }

+        var geographicLimitRectangleFlag = 0;
+        var geographicLimitRectangleDefine = '';
+        if (clippedByBoundaries) {//} && frameState.mode !== SceneMode.SCENE3D) {


Remove commented out code.

bagnell · 2018-09-06T21:18:56Z

Source/Scene/GlobeSurfaceTileProvider.js

+
+        /**
+         * A property specifying a {@link Rectangle} used to selectively prevent tiles outside a region from loading.
+         * For limiting terrain in scenes that use custom projections or Proj4JS projections that cause overlapping tiles.


I would remove the line about custom projections since this would likely get merged before support is added for them and that is not the only use case.

Prevents tiles from loading and also clips tiles on the boundary?

bagnell · 2018-09-06T21:37:19Z

It's strange that the performance drops in 2D only when showing the rectangles. I only get ~20 FPS.

bagnell · 2018-09-06T21:41:52Z

How hard would it be to change the center of projection? Columbus view might be useless if there is a limiting rectangle crossing the anti-meridian:

likangning93 · 2018-09-07T15:57:56Z

It's strange that the performance drops in 2D only when showing the rectangles. I only get ~20 FPS.

I'm seeing this in master as well, although not in the 1.49 release. Interesting thing, it doesn't happen if the scene starts in 2D. I'll write up an issue.

[EDIT] open here: #7018

likangning93 · 2018-09-07T17:22:00Z

How hard would it be to change the center of projection? Columbus view might be useless if there is a limiting rectangle crossing the anti-meridian:

Should be pretty easy in #6986, here's something that should work. Users might have to be careful with small polygons crossing the prime meridian though:

[EDIT] that is a strange looking morph

pjcozzi · 2018-09-10T12:20:16Z

Apps/Sandcastle/gallery/Geographic Limit Rectangle.html

+// Tropics of Cancer and Capricorn
+var coffeeBeltRectangle = Cesium.Rectangle.fromDegrees(-180, -23.43687, 180, 23.43687);
+
+viewer.scene.globe.geographicLimitRectangle = coffeeBeltRectangle;


Should this be called "cartographicLimitRectangle" given Cesium's Cartographic type? Same question for this filename and throughout.

Or just limitRectangle, cullRectangle, or whatever language is consistent with the rest of Cesium?

Let's go with cartographicLimitRectangle.

pjcozzi · 2018-09-10T12:20:53Z

Apps/Sandcastle/gallery/Geographic Limit Rectangle.html

+});
+
+// Tropics of Cancer and Capricorn
+var coffeeBeltRectangle = Cesium.Rectangle.fromDegrees(-180, -23.43687, 180, 23.43687);


Append .0 when the intention is floating point.

Throughout.

pjcozzi · 2018-09-10T12:24:03Z

Source/Shaders/GlobeFS.glsl

@@ -155,6 +159,15 @@ vec4 computeWaterColor(vec3 positionEyeCoordinates, vec2 textureCoordinates, mat

 void main()
 {
+
+#ifdef TILE_LIMIT_RECTANGLE


Is there a way to add a fast reject case to the vertex shader so that if the entire tile is outside the region, the vertex is moved beyond the camera like we do for billboards, etc.?

It shouldn't be necessary, the limiter is tied into tileset visibility computation. Tiles completely outside bounds won't get drawn and tiles completely inside bounds won't receive shader modification.

likangning93 · 2018-09-10T16:25:35Z

@bagnell @pjcozzi this is up-to-date

thw0rted · 2018-11-13T11:09:42Z

Hi all, you forgot to update the documentation for the Globe class. The new member in the public API isn't mentioned there. It looks like it's a Rectangle that defaults to undefined? Also, should it be possible to specify this at construction time, maybe by passing it to the constructor of the owning Scene?

kenghuo · 2018-11-27T02:50:58Z

Can i use other shape ?
Only 'rectangle'?

hpinkos · 2018-11-27T14:54:34Z

@kenghuo only rectangle is supported at this time

likangning93 mentioned this pull request Aug 31, 2018

Proj4 and custom projections #6901

Closed

4 tasks

add geographic limit rectangle

c94c510

likangning93 force-pushed the globeLimiterRectangle branch from f58f4d6 to c94c510 Compare August 31, 2018 16:16

likangning93 added 3 commits September 6, 2018 11:34

let geographic limit rectangle cross the IDL

569094f

Merge branch 'master' into globeLimiterRectangle

9fe6b02

update CHANGES.md

6cb3753

likangning93 requested a review from bagnell September 6, 2018 17:15

bagnell reviewed Sep 6, 2018

View reviewed changes

update doc

5bae8b3

likangning93 force-pushed the globeLimiterRectangle branch from 4085e92 to 5bae8b3 Compare September 7, 2018 17:29

pjcozzi reviewed Sep 10, 2018

View reviewed changes

PR comments

6e84ef5

bagnell merged commit d6ad77b into master Sep 10, 2018

bagnell deleted the globeLimiterRectangle branch September 10, 2018 19:54

lilleyse mentioned this pull request Jan 11, 2019

globe.cartographicLimitRectangle can't be unset #7477

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add geographic limit rectangle #6987

Add geographic limit rectangle #6987

likangning93 commented Aug 31, 2018 •

edited

Loading

cesium-concierge commented Aug 31, 2018 •

edited by likangning93

Loading

mramato commented Aug 31, 2018

hpinkos commented Aug 31, 2018

mramato commented Aug 31, 2018

likangning93 commented Sep 6, 2018

bagnell Sep 6, 2018

bagnell Sep 6, 2018

bagnell commented Sep 6, 2018

bagnell commented Sep 6, 2018

likangning93 commented Sep 7, 2018 •

edited

Loading

likangning93 commented Sep 7, 2018 •

edited

Loading

pjcozzi Sep 10, 2018

pjcozzi Sep 10, 2018

likangning93 Sep 10, 2018

pjcozzi Sep 10, 2018

pjcozzi Sep 10, 2018

likangning93 Sep 10, 2018

likangning93 commented Sep 10, 2018

thw0rted commented Nov 13, 2018

kenghuo commented Nov 27, 2018

hpinkos commented Nov 27, 2018

Add geographic limit rectangle #6987

Add geographic limit rectangle #6987

Conversation

likangning93 commented Aug 31, 2018 • edited Loading

cesium-concierge commented Aug 31, 2018 • edited by likangning93 Loading

mramato commented Aug 31, 2018

hpinkos commented Aug 31, 2018

mramato commented Aug 31, 2018

likangning93 commented Sep 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bagnell commented Sep 6, 2018

bagnell commented Sep 6, 2018

likangning93 commented Sep 7, 2018 • edited Loading

likangning93 commented Sep 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

likangning93 commented Sep 10, 2018

thw0rted commented Nov 13, 2018

kenghuo commented Nov 27, 2018

hpinkos commented Nov 27, 2018

likangning93 commented Aug 31, 2018 •

edited

Loading

cesium-concierge commented Aug 31, 2018 •

edited by likangning93

Loading

likangning93 commented Sep 7, 2018 •

edited

Loading

likangning93 commented Sep 7, 2018 •

edited

Loading