Fix isCrossOriginUrl in IE for real #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an inconsistency in IE between a.href and window.location about whether default ports are included or not.
|
Failed in |
mramato
added a commit
that referenced
this pull request
Apr 30, 2013
…rl_in_ie Fix isCrossOriginUrl in IE for real
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests I meticulously added failed in IE8 if you ran the tests on port 80 instead of 8080.
Put both the window URL and the test URL through an anchor. Fixes an inconsistency in IE between a.href and window.location about whether default ports are included or not.