-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to turn off normal shading #7399
Conversation
Thanks for the pull request @Vineg!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Thanks @Vineg. Would you mind opening a separate PR for the point cloud changes so that we can focus on the geometric error fix exclusively? |
Ok, tomorrow |
ca38e70
to
a563bda
Compare
@Vineg is this ready for review now? Next time, make a comment when it's ready so we get notified. We don't get notified when you push new commits. Thanks! |
Thanks again for your contribution @Vineg! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
@lilleyse can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Vineg, the approach looks good. Just some minor comments.
Also some variables renamed, description changed
@lilleyse I think this is ready. @Vineg @geoscan-builder next time you push commits after a review, post a comment when the PR is ready for another look. We don't get notifications when commits are pushed up so we missed that you were working on this. Thanks! |
Thanks for the updates @Vineg. I just tweaked a few things and updated documentation and |
Small fixes.
#5152