Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIT when toggling HDR. #7451

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Fix OIT when toggling HDR. #7451

merged 2 commits into from
Jan 2, 2019

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Jan 2, 2019

Fixes #7380. The OIT buffers need to be recreated when HDR is toggled.

I tried to write a test, but I couldn't get it to fail in master.

@cesium-concierge
Copy link

Thanks for the pull request @bagnell!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@lilleyse
Copy link
Contributor

lilleyse commented Jan 2, 2019

Thanks @bagnell. Looks good.

@lilleyse lilleyse merged commit db83ba6 into master Jan 2, 2019
@lilleyse lilleyse deleted the hdr-toggle branch January 2, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants