Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KHR_texture_transform #7549

Merged
merged 7 commits into from
Apr 7, 2019
Merged

Add support for KHR_texture_transform #7549

merged 7 commits into from
Apr 7, 2019

Conversation

@cesium-concierge
Copy link

cesium-concierge commented Feb 7, 2019

Thanks for the pull request @bagnell!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@bagnell
Copy link
Contributor Author

bagnell commented Feb 7, 2019

Here is a Sandcastle example of a textured box using the scale property of the extension to repeat the texture 3x in the t direction and 5x in the s direction:

var viewer = new Cesium.Viewer('cesiumContainer');
var entity = viewer.entities.add({
    position : Cesium.Cartesian3.fromDegrees(-123.0744619, 44.0503706, 10.0),
    model : {
        uri : '../../../Specs/Data/Models/Box-Texture-Transform/CesiumTexturedBoxTest.gltf',
        minimumPixelSize : 128,
        maximumScale : 20000
    }
});
viewer.trackedEntity = entity;

Source/Scene/processPbrMaterials.js Outdated Show resolved Hide resolved
Source/Scene/processPbrMaterials.js Outdated Show resolved Hide resolved
Source/Scene/processPbrMaterials.js Outdated Show resolved Hide resolved
@cesium-concierge
Copy link

Thanks again for your contribution @bagnell!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@bagnell
Copy link
Contributor Author

bagnell commented Mar 21, 2019

@lilleyse This is ready for another look.

@emackey
Copy link
Contributor

emackey commented Mar 21, 2019

Looking good. This will pass the Khronos sample model test.

TexTransformTest

@lilleyse lilleyse force-pushed the texture-transform branch from cd0195a to b36e12e Compare April 7, 2019 17:30
@lilleyse lilleyse force-pushed the texture-transform branch from b36e12e to 4467d23 Compare April 7, 2019 17:31
@lilleyse
Copy link
Contributor

lilleyse commented Apr 7, 2019

The updates look good. Thanks @bagnell.

@lilleyse lilleyse merged commit ead4bb5 into master Apr 7, 2019
@lilleyse lilleyse deleted the texture-transform branch April 7, 2019 18:06
@emackey
Copy link
Contributor

emackey commented Apr 8, 2019

@cx20 Texture transform should appear in the May 1 release of Cesium 1.57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants