-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for KHR_texture_transform #7549
Conversation
Thanks for the pull request @bagnell!
Reviewers, don't forget to make sure that:
|
Here is a Sandcastle example of a textured box using the scale property of the extension to repeat the texture 3x in the var viewer = new Cesium.Viewer('cesiumContainer');
var entity = viewer.entities.add({
position : Cesium.Cartesian3.fromDegrees(-123.0744619, 44.0503706, 10.0),
model : {
uri : '../../../Specs/Data/Models/Box-Texture-Transform/CesiumTexturedBoxTest.gltf',
minimumPixelSize : 128,
maximumScale : 20000
}
});
viewer.trackedEntity = entity; |
Thanks again for your contribution @bagnell! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
@lilleyse This is ready for another look. |
cd0195a
to
b36e12e
Compare
b36e12e
to
4467d23
Compare
The updates look good. Thanks @bagnell. |
@cx20 Texture transform should appear in the May 1 release of Cesium 1.57. |
https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_texture_transform/README.md