Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tapered glowing lines as an option on PolylineGlowMaterial. #7626

Merged
merged 9 commits into from
Apr 24, 2019

Conversation

emackey
Copy link
Contributor

@emackey emackey commented Mar 8, 2019

This adds a new uniform parameter to PolylineGlowMaterial called taperPower, to go alongside the existing glowPower parameter.

When set, this parameter will taper off the glowing line, using a strength falloff profile that matches the glowPower falloff for the equivalent number.

The default value is 1.0. Numbers 1.0 and higher produce no tapering effect, so, the default behavior will exactly replicate the look of PolylineGlowMaterial prior to the introduction of this new parameter.

The core of what actually changed here is in the file PolylineGlowMaterial.glsl.

The best sample usage of this new parameter is in the HeadingPitchRoll demo, where the aircraft now leaves behind a tapered glowing line, simply by adding the new parameter to its code. Use the arrow keys to steer the aircraft.

taperlinedemo

@cesium-concierge
Copy link

cesium-concierge commented Mar 8, 2019

Thanks for the pull request @emackey!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works in IE11.

@emackey
Copy link
Contributor Author

emackey commented Mar 8, 2019

More demo fun.

TaperExplosion

@emackey
Copy link
Contributor Author

emackey commented Mar 11, 2019

I merged master in here, but the tests failed. The failures look like they might be related to #7579, createImageBitmap.

@emackey
Copy link
Contributor Author

emackey commented Mar 12, 2019

Merged master again, nothing test-related there, but tests pass this time.

@emackey
Copy link
Contributor Author

emackey commented Mar 18, 2019

This is ready.

@bagnell
Copy link
Contributor

bagnell commented Apr 24, 2019

👍 Thanks @emackey.

@iamsee
Copy link

iamsee commented Jul 12, 2020

@emackey the demo page is 404
image

@OmarShehata
Copy link
Contributor

@iamsee you can get the updated demo URL by taking the same query parameters with the sandcastle.cesium.com domain. Here's a working link.

@iamsee
Copy link

iamsee commented Jul 17, 2020

@OmarShehata thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants