Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed an Error where the AnchorlineColor reused the given color #7686

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

jbo023
Copy link
Contributor

@jbo023 jbo023 commented Mar 28, 2019

AnchorLineColor in the Vector3DTilePoints is using a scratchColor to set the Color to the Cesium3DTilePointFeature. This only works when the function clones the Color, otherwise all colors take the value of the last feature.
https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Scene/Vector3DTilePoints.js#L425

@cesium-concierge
Copy link

Thanks for the pull request @jbo023!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

Thanks @jbo023, the fix looks good to me.

@lilleyse lilleyse merged commit 646faf6 into CesiumGS:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants