Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BingMapsStyle to match imagery provided by Bing Maps #7721

Closed
wants to merge 1 commit into from
Closed

Update BingMapsStyle to match imagery provided by Bing Maps #7721

wants to merge 1 commit into from

Conversation

tangtony
Copy link

@tangtony tangtony commented Apr 6, 2019

From https://docs.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata:

AerialWithLabels (Deprecated): Aerial imagery with a road overlay, using the legacy static tile service. This service is deprecated and current data will not be refreshed. New applications should instead use AerialWithLabelsOnDemand.

Road (Deprecated): Roads without additional imagery, using the legacy static tile service. This service is deprecated and current data will not be refreshed. New applications should instead use RoadOnDemand.

Related: #7128

Not sure if there's anything else that needs to be updated, but I did a quick test and it seems to work with the new values.

@cesium-concierge
Copy link

Thank you so much for the pull request @tangtony! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@shunter
Copy link
Contributor

shunter commented May 3, 2019

Superseded by #7808 which also included fixes for the discard tile policy with the new imagery types.

@shunter shunter closed this May 3, 2019
@cesium-concierge
Copy link

Thanks for the awesome work @tangtony! Your contribution is about to launch to millions of users with the next release. 🚀

Do you mind if we tweet about it? CC @OmarShehata @slchow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants