Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send ion access token to non-ion servers #7839

Merged
merged 3 commits into from
May 15, 2019
Merged

Don't send ion access token to non-ion servers #7839

merged 3 commits into from
May 15, 2019

Conversation

mramato
Copy link
Contributor

@mramato mramato commented May 14, 2019

@tfili can you review. @OmarShehata this should fix the issue you uncovered.

Some ion-hosted assets can still point to additional external servers as, part of their dataset. We were still appending the ion access_token in the Accept header to these servers, which is at best pointless but at worst would cause some CORS requests to fail because the Accept header was not allowed.

Some ion-hosted assets can still point to additional external servers as,
part of their dataset. We were still appending the ion access_token in
the Accept header to these servers, which is at best pointless but at worst
would cause some CORS requests to fail because the Accept header was not
allowed.
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@tfili tfili merged commit 37cacdf into master May 15, 2019
@tfili tfili deleted the ion-cors branch May 15, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants