Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for #7990 #7998

Merged
merged 7 commits into from
Jul 31, 2019
Merged

Patch for #7990 #7998

merged 7 commits into from
Jul 31, 2019

Conversation

ppoulainpro
Copy link
Contributor

This patch solves #7990 and also a similar issue when globe shading is active.

@cesium-concierge
Copy link

Thanks for the pull request @ppoulainpro!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@ppoulainpro ppoulainpro marked this pull request as ready for review July 15, 2019 04:44
@lilleyse
Copy link
Contributor

I just made some small cleanup changes in 7bd5d7d. Thanks for the fix @ppoulainpro!

@lilleyse lilleyse merged commit 30d215b into CesiumGS:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppoulainpro @cesium-concierge @lilleyse