-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing wall segments for some extruded polygons #8035
Conversation
Thanks for the pull request @likangning93!
Reviewers, don't forget to make sure that:
|
@likangning93 do you have a sandcastle example to reproduce this? Your fix doesn't look right to me. |
I can confirm this fixes the issue I was seeing which came up on the forum here. |
I'll take a closer look at this soon |
Thanks again for your contribution @likangning93! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Replaced by #8177 |
Congratulations on closing the issue! I found these Cesium forum links in the comments above: https://groups.google.com/d/msg/cesium-dev/kaAIg-6-XdM/-ob0p_wlBgAJ If this issue affects any of these threads, please post a comment like the following:
|
When generating vertices and indices for extruded polygons, we only generate indices for vertices that aren't too close together. However, the array that we were allocating for these indices was sometimes too small, which was most apparent with rhumbline polygons like geojson. This PR allocates a larger array up-front and slices it down to size after all indices have been generated.
I'm not 100% sure how the original index count was computed, @hpinkos @lilleyse is any of that familiar?