Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index option for adding primitive to PrimitiveCollection #8041

Merged
merged 3 commits into from
Aug 5, 2019
Merged

index option for adding primitive to PrimitiveCollection #8041

merged 3 commits into from
Aug 5, 2019

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Aug 5, 2019

I have a use case where I need to add a primitive to the collection at index 0. This mimics what ImageryLayerCollection does.

@cesium-concierge
Copy link

cesium-concierge commented Aug 5, 2019 •
edited by likangning93
Loading

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

likangning93
likangning93 reviewed Aug 5, 2019
View reviewed changes
Copy link
Contributor

@likangning93 likangning93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpinkos just one comment, otherwise looks good:

Source/Scene/PrimitiveCollection.js Outdated Show resolved Hide resolved
@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 5, 2019

Thanks @likangning93, ready!

@likangning93
Copy link
Contributor

Does this also warrant an update to CHANGES.md?

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 5, 2019

Sure! why not

@likangning93 likangning93 merged commit 7a6d4b0 into master Aug 5, 2019
@likangning93 likangning93 deleted the primitive-index branch August 5, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likangning93 likangning93 likangning93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hpinkos @cesium-concierge @likangning93