Fixed pixel size for polylines and point clouds under different resolutions #8227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #8113
Polylines and point clouds had a number of areas that were not consistently sized between different resolutions:
Point cloud
new (low res):
new (high res):
cesium 1.60 (low res):
Polylines
new (low res):
new (high res):
cesium 1.60 (low res):
Further thoughts:
PolylineShadowVolumeMorphVS.glsl
, which "spawns" theczm_batchTable_width
function prior to shader compilation, where there is no easy way to insert the pixel ratio multiply.getPointSizeFromStyle
inPointCloud.js
has the same problem.renderState's
lineWidth
property still look incorrect. This is because they are rendered as GL lines which is capped to 1 pixel on many computers. Example below:Native resolution:
Browser recommended resolution: