Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix water material alpha #8455

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Fix water material alpha #8455

merged 2 commits into from
Dec 16, 2019

Conversation

lilleyse
Copy link
Contributor

The base water color was not contributing to the material's alpha.

Local sandcastle

water

@lilleyse lilleyse requested a review from IanLilleyT December 11, 2019 23:46
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

Copy link
Contributor

@IanLilleyT IanLilleyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is consistent with the material.diffuse code.

@IanLilleyT IanLilleyT merged commit 2dcbe6c into master Dec 16, 2019
@IanLilleyT IanLilleyT deleted the water-material-alpha branch December 16, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants