Made GlobeSurfaceTile.pick not pick triangles behind the ray #8499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced this bug in #8390 (mid-December 2019). The old way uses
IntersectionTests.rayTriangle
which returnsundefined
when the triangle is behind the ray. The new way usesIntersectionTests.rayTriangleParametric
which returns a negative distance when the triangle is behind the ray. Since I never added a check for this inGlobeSurfaceTile.pick
, triangles behind the ray could be picked. I added a comment and another picking test to avoid this confusion in the future.Fortunately this bug never made it into an official release.
@lilleyse Let's get this in before the January release.