Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terrain tile picking in Cesium Inspector #8567

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

lilleyse
Copy link
Contributor

Replaced camera.pickEllipsoid with globe.pick so it actually picks terrain instead of the ellipsoid.

Sandcastle - click the top of the mountain in the center

Before
2
After
1

@lilleyse lilleyse requested a review from IanLilleyT January 24, 2020 22:29
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse lilleyse force-pushed the cesium-inspector-pick-fix branch from 32794ec to 28e23d0 Compare January 24, 2020 22:30
@hpinkos
Copy link
Contributor

hpinkos commented Jan 24, 2020

Works great @lilleyse, thanks! I'll merge as soon as CI passes

@lilleyse
Copy link
Contributor Author

@hpinkos I merged in master, this should be ready to go now.

@hpinkos hpinkos merged commit a1daf6e into master Jan 28, 2020
@hpinkos hpinkos deleted the cesium-inspector-pick-fix branch January 28, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants