Handling zero origin for localFrameToFixedFrame #8571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8570
#8475 exposed a bug where calling
viewer.zoomTo(tileset)
on a root tile (or any tile centered at zero) would crash. Ultimately this was caused byTransforms.eastNorthUpToFixedFrame
not handling the zero vector case and returning a bad transformation matrix. Since ENU is not well defined at zero, I return thedegeneratePositionLocalFrame
matrix instead, which is similar to how the north and south pole are handled.@loshjawrence