Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cesium release server work on Node 12. #8648

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Make Cesium release server work on Node 12. #8648

merged 1 commit into from
Mar 2, 2020

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Mar 2, 2020

While we still can't use Node 12 for Cesium development, this change is to make sure Cesium release zips can actually work under Node 12.

While we still can't use Node 12 for Cesium development, this change is
to make sure Cesium release zips can actually work under Node 12.
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

lilleyse commented Mar 2, 2020

Works for me in Node 10.19.0 and 12.16.1

@lilleyse lilleyse merged commit dbba447 into master Mar 2, 2020
@lilleyse lilleyse deleted the node-12 branch March 2, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants