-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing highp issue - Batch Tables #8805
Conversation
Thanks for the pull request @YoussefV!
Reviewers, don't forget to make sure that:
|
@likangning93 mentions in the linked issue that we should roll back #7421, is that still the case? |
@mramato Just addressed this in the latest commit. The answer turned out to be yes, but not exactly. Because #7421 was fairly old, it needed careful rolling back. Latest push should have fixed it. I needed to only remove code that was related to the high precision issue, which was a little involved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @YoussefV! Just one small code comment.
Also, since the fix here is at the batch-table level it should also help anyone who's storing float attributes with primitives on mobile, can you also update CHANGES.md
for that?
Fixes #8311