Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space to JSDoc attributes #8835

Merged
merged 1 commit into from
May 12, 2020
Merged

Add space to JSDoc attributes #8835

merged 1 commit into from
May 12, 2020

Conversation

vrana
Copy link
Contributor

@vrana vrana commented May 10, 2020

I select text using double click a lot - it selects whole words so that I don't need to be that precise in selecting the beginning of a word and the end of it. The words are delimited by a space, not by visual look. If I try to select e.g. Cesium.Cartographic.ZERO in the Cesium docs using this method then it results in staticconstantCesium.Cartographic.ZERO being selected because there are no spaces after static and constant. This commit adds the spaces there.

Tested: jsdoc -c Tools/jsdoc/conf.json

I select text using double click a lot - it selects whole words so that I don't need to be that precise in selecting the beginning of a word and the end of it. The words are delimited by a space, not by visual look. If I try to select e.g. `Cesium.Cartographic.ZERO` in the Cesium docs using this method then it results in `staticconstantCesium.Cartographic.ZERO` being selected because there are no spaces after `static` and `constant`. This commit adds the spaces there.

Tested: jsdoc -c Tools/jsdoc/conf.json
@cesium-concierge
Copy link

Thanks for the pull request @vrana!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented May 12, 2020

Thanks!

@mramato mramato merged commit d8145e7 into CesiumGS:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants