Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageryLayer.nightAlpha option for night textures #8862

Closed
wants to merge 10 commits into from

Conversation

epranka
Copy link

@epranka epranka commented May 17, 2020

First of all, this is my first pull request, so sorry if something is wrong.

EDIT:
I closed this pull request because of this: #8868

I added the nightAlpha option to the ImageryLayer class. It lets show and blend textures only on the shade side of the globe. This only takes effect when enableLighting is true.

The main reason to do this was to have day and night Earth textures depending on the lighting as an example below.

If nightAlpha = 0.0 (default value), it doesn't take any effect.
If nightAlpha > 0.0, the layer is only blended on shade side and has an alpha channel equal to nightAlpha

Also, I created the showcase of it called Night textures on the shade side in the Sandcastle.

Earth night textures example

@cesium-concierge
Copy link

Thanks for the pull request @epranka!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@epranka epranka marked this pull request as draft May 17, 2020 19:15
@epranka
Copy link
Author

epranka commented May 18, 2020

Close because of #8868

@epranka epranka closed this May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants