Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ScreenSpaceEventHandler.getInputAction JSDoc #9002

Merged
merged 5 commits into from
Jun 30, 2020

Conversation

sanjeetsuhag
Copy link
Contributor

@sanjeetsuhag sanjeetsuhag commented Jun 29, 2020

Fixes #8929.

Added a @returns section to JSDoc for getInputType.

@cesium-concierge
Copy link

Thanks for the pull request @sanjeetsuhag!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Jun 29, 2020

Thanks @sanjeetsuhag! This doesn't actually fix #8945, since the actual event objects are still not typed, but it looks like it does fix #8929.

One CI passes I'll take a quick look and most likely merge.

@sanjeetsuhag
Copy link
Contributor Author

@mramato Thanks! Updated the description.

@mramato
Copy link
Contributor

mramato commented Jun 30, 2020

Thanks again.

@mramato mramato merged commit 3b54b9d into master Jun 30, 2020
@mramato mramato deleted the screenspaceeventhandlder-jsdoc branch June 30, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getInputAction is wrongly typed
3 participants