Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the return statetment as SampledProperty removeSample is return… #9017

Conversation

vipulgusain
Copy link
Contributor

fixed the return statement as SampledProperty removeSample is returning
but this function is not even though the api docs states it should

…ing but this function is not even though the api docs states it should
@cesium-concierge
Copy link

Thank you so much for the pull request @vipulgusain! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@vipulgusain
Copy link
Contributor Author

vipulgusain commented Jul 3, 2020

Contributor License Agreement (CLA) signed and submited

@vipulgusain vipulgusain marked this pull request as ready for review July 3, 2020 13:57
@vipulgusain
Copy link
Contributor Author

"this is ready"

@hpinkos
Copy link
Contributor

hpinkos commented Jul 9, 2020

Thanks for the PR @vipulgusain! At a glance this looks good, but I'll have time to do a thorough review and get this merged next week sometime

@hpinkos
Copy link
Contributor

hpinkos commented Jul 20, 2020

Thanks @vipulgusain! I'll merge as soon as CI passes

@hpinkos hpinkos merged commit b2d0fe6 into CesiumGS:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants