Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAB-1658 Improve ImageryLayer.cancelReprojections() handling #9161

Conversation

chris-cooper
Copy link
Contributor

This was a bugfix that @kring helped us with a while back. From memory it was causing problems in an ImageryLayer when a terrain provider was swapped out on a globe.

@cesium-concierge
Copy link

Thanks for the pull request @chris-cooper!

  • ❕ There was an error checking the CLA! If this is your first contribution, please send in a Contributor License Agreement.
    • Maintainers, this was the error I ran into while attempting to process the CLA check. Please resolve it to continue CLA checking.
    Error: The service is currently unavailable.
    
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@kring
Copy link
Member

kring commented Sep 21, 2020

Thanks for opening this, @chris-cooper! I believe this fixes #6021. I'm going to push this into a branch in the main repo so make it easier to test.

@kring
Copy link
Member

kring commented Sep 21, 2020

Confirmed I can't reproduce #6021 in this branch, but I can in master.

@chris-cooper
Copy link
Contributor Author

Moved to #9163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants